lentinj
commented
1 year ago FWIW you can reproduce this with the real thing via:
g3_eval(gadget3:::g3a_grow_impl_bbinom(
delta_len_f = 10,
delta_wgt_f = NA,
beta_f = 1000,
maxlengthgroupgrowth = 1)$len, list(stock__plusdl = 1))as it is common practice to set this value roughly as the maximum possible growth,
I think there's some naming muddling here, which isn't helping.
binn within growth_bbinom() is always maxlengthgroupgrowth. But we make a default parameter for beta_f called "stock_name.binn".
When poking the growth equation I noticed an oddity that I hadn't thought about before. When the beta-binomial (implemented at https://github.com/gadget-framework/gadget3/blob/master/R/action_grow.R#L66 ) is supplied with a
delta_l>binnthe sum of the entries is no longer 1, e.g.results in
19, and thus could lead to increasing the number of fish in the model. Although I guess this is not very likely to occur in a final model, as it is common practice to set this value roughly as the maximum possible growth, we should probably think of something to ensure that this does not cause problems.