gadget-framework / gadget3

TMB-based gadget implemtation
GNU General Public License v2.0
8 stars 6 forks source link

g3a_report_detail error #125

Closed MikkoVihtakari closed 7 months ago

MikkoVihtakari commented 9 months ago

Apologies for possibly not helpful bug report...When I run our Greenland halibut model short-term projetions using the GitHub version of gadget3, I get:

proj_actions <- c(proj_actions,
+                   list(gadget3::g3a_report_detail(proj_actions, run_f = ~TRUE)))
Error in g3a_report_history(actions = actions, var_re = c("__renewalnum$",  : 
  Don't know how to add history to ghl_female_imm__predby_fleet_stock: NULL

The code works without problems using the CRAN version of gadget3. Perhaps someone can guess where the error is given the recent changes.

lentinj commented 9 months ago

The problem is ridiculously likely to be https://github.com/gadget-framework/gadget3/commit/4b113863cd1885960923a4462e2c120ca8d1e749. My guess is g3experiments isn't updated, and you're missing the corresponding commit there https://github.com/gadget-framework/g3experiments/commit/2f674c0de965b66c504bbf14e3e14960fdf0d120

(also, I'm guessing g3a_predate_catchability_hockeyfleet isn't really an experiment any more)

MikkoVihtakari commented 9 months ago

Thanks Jamie. I thought I updated g3experiments. I'll check later.

bthe commented 8 months ago

(also, I'm guessing g3a_predate_catchability_hockeyfleet isn't really an experiment any more)

yes, the code for the function is however still a bit messy, might be worthwhile to kick the tires a bit before it is included in g3 proper.

lentinj commented 7 months ago

I'm guessing this is fine now, closing.