g3a_report not compatible with g3a_trace_nan

gadget-framework / gadget3

TMB-based gadget implemtation

GNU General Public License v2.0

8 stars 6 forks source link

g3a_report not compatible with g3a_trace_nan #130

Closed lentinj closed 5 months ago

lentinj commented 8 months ago

g3a_trace_nan() generates experiments nan_ prefixed variables, which flummox g3a_report_*. Either:-

We need to explicitly ignore these by name (in which case the name should be more unique)
We need to not report on g3_global_formula objects (but there may be a use case for this one day?)

Generally we need something stopping you trying to optimise models with g3a_trace_nan(), since it'll cause all sorts of havoc.

lentinj commented 5 months ago

I'm not sure there's anything to immediately do beyond give them more obvious names. Maybe if we have a model modifier pipeline in #131 it will make it easier to not do this by accident.