Add g3a_spawn_recruitment_bevertonholt_ss3

gadget-framework / gadget3

TMB-based gadget implemtation

GNU General Public License v2.0

8 stars 6 forks source link

Add g3a_spawn_recruitment_bevertonholt_ss3 #172

Closed lentinj closed 1 month ago

lentinj commented 1 month ago

@bthe Care to look over before it gets merged?

It's slightly different to the g3experiments version:

I couldn't work out why - s was added, so removed it
Added per-year random deviates in a separate variable, rather than adding "R0.scalar". I think this makes it slightly easier to understand.

bthe commented 1 month ago

Have no idea where this rougue -s came from, so nicely spotted.

Regarding including recruitment deviates or not, the reason for I didn't include it is that we don't do it in any other function (spawning or otherwise) where we would potentially want to have timevariation so I guess adding a special parameter would be inconsistent with what we have done so far?

lentinj commented 1 month ago

True, and g3_parameterized("R", by_stock = TRUE, by_year = TRUE, exponentiate = TRUE, scale = "R0") is entirely equivalent to the 2 parameters I've added anyway.

I was trying to go for an obvious parallel to the SS3 documentation, but maybe I'm just getting carried away. I'll switch it to the above and commit.