gadget-framework / gadget3

TMB-based gadget implemtation
GNU General Public License v2.0
8 stars 5 forks source link

Combined g3_param_table / g3l_random_dnorm() #181

Open lentinj opened 3 months ago

lentinj commented 3 months ago

We have random deviates with g3_param_table() & g3l_random_dnorm(), need to expand this for a projection.

See:

lentinj commented 3 months ago

@bthe / @vbartolino for reporting of values, would it be better to have a combined array of random deviates & projected deviates, or just projected values and rely on parameter table for former? I'm assuming a combined array is more useful, but would be good to know if you think otherwise.

bthe commented 3 months ago

Would this mean that the values for the random effects would not appear in the parameter table?

vbartolino commented 3 months ago

does one option exclude the other? if possible I think it would be useful to have both and in any case intuitively a user would expect to find the parameters of the random effect in the parameter table

lentinj commented 3 months ago

Yes, the random effects will be in the parameter table regardless, having them in the report array won't affect that.

This is mostly a question of how to structure the array internally. If we want a report to include the random effects before projection, then I'll arrange to code so that happens by default.

bthe commented 3 months ago

OK, then I would think that most logical thing would be, as you suggest, to have both the estimated random effect and projected values.