search

gadget-monk / homebridge-poolcontroller

Homebridge plugin for Pentair pools
6 stars 4 forks source link

Update heater state utility functions & body accessory to fix issues with getting/setting heater state #15

Closed michaelmedellin closed 1 year ago

michaelmedellin commented 1 year ago

Two issues fixed here:

  1. When setting heater state, the values in the utility functions were sending values of 0 and 1, instead of 1 and 2. I’m not sure why the nodejs pool controller API requires 1 and 2 for heater specifically, but 1 is off and 2 is heat. These changes update this so it works from Homekit. Before this, if you changes the heater state from Homekit it would turn off but never turn back on which isn’t useful if wanting to turn on heat from Homekit.
  2. This fixes the logging issue with the incorrect value being set for the target temp state logged in the homebridge logs. This issue no longer appears with these changes.
michaelmedellin commented 1 year ago

@gadget-monk I’m new to this repository, so I’m unfamiliar with some of the changes/edits here. After testing for a bit, everything seems to work on my local plugin install. Happy to make edits where required. Cheers.

gadget-monk commented 1 year ago

Thank you so much for making the edits. I am not actively maintaining this plugin anymore since I moved to using home assistant. Maybe I can update the intro page and point people to your GitHub page for latest version?