search

gadgetto / GoodNews

An integrated group and newsletter mailing system for MODX Revolution CMF
GNU General Public License v2.0
10 stars 4 forks source link

Server protocol in sent mails #55

Closed devlanda closed 7 years ago

devlanda commented 7 years ago

When I send a mailing via GoodNews from a https enabled website, the actual mail does not contain link references to https but to http. For instance the Read it online, Unsubscribe and Edit Mailing Profile links.

Updating the system setting 'server_protocol' from http to https does not change the outcome. It can be solved with the context setting 'site_url'. However, it would be nice if GoodNews picks up the protocol automatically.

Additional: In the online preview of the mailing the protocol is respected well.

gadgetto commented 7 years ago

GoodNews currently is indeed completing URLs only based on site_url setting.

As I wrote this part of code I thought the site_url setting is the best way to determine the scheme of the websites URL. In the meantime I learned that site_url is a dynamically generated system setting.

Shouldn't be the site_urlvalue be updated automatically if you change the server_protocol?

gadgetto commented 7 years ago

Just found this issue on MODX GitHub page: https://github.com/modxcms/revolution/issues/13269

Seems that server_protocol does indeed nothing currently and should be removed completely. site_url setting is the way to go.

Therefore I won't change GoodNews behavior until the case is closed/fixed on MODX side.