search

gadgetto / GoodNews

An integrated group and newsletter mailing system for MODX Revolution CMF
GNU General Public License v2.0
10 stars 4 forks source link

Preview doesn't show images #78

Closed funkyduke closed 4 years ago

funkyduke commented 4 years ago

The preview inside Modx doesn't show the images inserted with the editor (Redactor v3). If you send a testmail the images are OK in the mail.

gadgetto commented 4 years ago

Can't reproduce this. The mail preview uses the same methods as each other MODX resource to render the preview. Is the preview working in other (none GoodNews) resource documents? Could you try to test this using the built in editor?

funkyduke commented 4 years ago

OK, I forgot the base tag in the template. I think you should also put it in sample.GoodNewsNewsletterTemplate1 and sample.GoodNewsNewsletterTemplate2.

gadgetto commented 4 years ago

You don’t need the base tag, as GoodNews automatically completes relative URLs to full URLs.

funkyduke commented 4 years ago

I think you need it for the preview in Modx, otherwise the image is not showed. Without base url the image was not visible in the preview, with base url it's visible.

gadgetto commented 4 years ago

I’m always using root-relative URLs (/path/to/image.jpg). My WYSIWYG editors are configured to work this way. But using a base tag should also work.

Am 10.05.2020 um 01:31 schrieb Houwen Frederik notifications@github.com:

I think you need it for the preview in Modx, otherwise the image is not showed. Without base url the image was not visible in the preview, with base url it's visible.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/gadgetto/GoodNews/issues/78#issuecomment-626249357, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGWBQIGPUJL5OJNOXH7VTDRQXRU7ANCNFSM4M4IWX6A.

funkyduke commented 4 years ago

OK, but maybe it's a good idea to have it in the documentation somewhere.