TOTK imgs returning server error

gadhagod / Hyrule-Compendium-API

An API serving data on all in-game items and regions in Breath of the Wild and Tears of the Kingdom.

https://gadhagod.github.io/Hyrule-Compendium-API/#/

MIT License

190 stars 29 forks source link

TOTK imgs returning server error #43

Closed XavierLora closed 5 months ago

gadhagod commented 8 months ago

Just saw this, thanks for letting me know. For some reason, the tests are not catching this error. I'm taking a look right now.

ManuelMunozDeFrutos commented 5 months ago

Hello! I'm testing the API but TOTK Images don't work. Any issue?

XavierLora commented 5 months ago

It hasn't been fixed since the original comment, unsure what would need to go into fixing it. I started a new job around when I posted this but I can make time if there is a desire and @gadhagod wants to make it happen. No stress or worries either way!

gadhagod commented 5 months ago

Thanks for bringing this to my attention again @ManuelMunozDeFrutos. That endpoint should now be throwing a 501 Not Implemented error instead of an internal server error. This is the expected behaviour as TOTK images have not been added yet.

Congratulations on the new job @XavierLora! I'll try to revive this project in terms of development this summer (school ends in one day), and hope to have TOTK images up soon. I apologize for such a late response!