gadicc / meteor-messageformat

MessageFormat i18n support for Meteor, with reactive templates
54 stars 22 forks source link

Fail softer when format text is broken #244

Closed sbalmer closed 8 years ago

sbalmer commented 8 years ago

Hi there!

We had some trouble tracking down a broken translation string. Because broken format strings are a common occurrence for us, I'd like to improve error handling. This patch causes mf() to retry in the native language should the translated string fail.

Thanks for having a look at this. I'm not sure this is the best way to go about it, but at least our site won't show [Object object] messages anymore this way :-)

Cheers Stephan

gadicc commented 8 years ago

Love these! :) Looks perfect to me, thanks so much. Released in msgfmt:core@2.0.0-preview.23.

sbalmer commented 8 years ago

Thanks Gadi!