search

gadicc / node-yahoo-finance2

Unofficial API for Yahoo Finance
https://www.npmjs.com/package/yahoo-finance2
MIT License
388 stars 62 forks source link

Failed validation: #/definitions/QuoteSummaryResult #197

Open blaur opened 3 years ago

blaur commented 3 years ago

Seeing this for ORSTED.CO

"error":{"name":"FailedYahooValidationError","errors":[{"instancePath":"/price/shortName","message":"must be string","schemaPath":"#/definitions/Price/properties/shortName/type","params":{"type":"string"},"keyword":"type","data":null}],"result":{"price":{"quoteType":"EQUITY","shortName":null,"regularMarketPrice":925.8,"marketCap":388898947072,"currency":"DKK","marketState":"PREPRE","regularMarketOpen":926.2,"regularMarketVolume":423244,"regularMarketDayHigh":945,"priceHint":2,"regularMarketChangePercent":0.0032509754,"longName":"Ørsted A/S","regularMarketSource":"FREE_REALTIME","toCurrency":null,"regularMarketDayLow":916.6,"exchangeDataDelayedBy":0,"lastMarket":null,"symbol":"ORSTED.CO","fromCurrency":null,"maxAge":1,"quoteSourceName":"Delayed Quote","exchangeName":"Copenhagen","underlyingSymbol":null,"regularMarketChange":3,"exchange":"CPH","currencySymbol":"kr.","regularMarketTime":{},"regularMarketPreviousClose":922.8}}

gadicc commented 3 years ago

:tada: This issue has been resolved in version 1.12.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

gadicc commented 3 years ago

Oops, didn't mean to close this, but it's fixed now in the latest release. If you can confirm, you can close. Thanks :) And thanks for reporting!

blaur commented 3 years ago

Seeing this now:

node_modules/yahoo-finance2/node_modules/ajv/dist/types/json-schema.d.ts:1:92 - error TS1005: '?' expected.

1 declare type StrictNullChecksWrapper<Name extends string, Type> = undefined extends null ? `strictNullChecks must be true in tsconfig to use ${Name}` : Type;
                                                                                             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/yahoo-finance2/node_modules/ajv/dist/types/json-schema.d.ts:1:151 - error TS1005: ';' expected.

1 declare type StrictNullChecksWrapper<Name extends string, Type> = undefined extends null ? `strictNullChecks must be true in tsconfig to use ${Name}` : Type;

Seems like something is missing in the schemda.d.ts? because i have strictNullChecks: true in my tsconfig

gadicc commented 3 years ago

Hey @blaur, I'm moving my reply to https://github.com/gadicc/node-yahoo-finance2/issues/198 for clarity. Let's continue this part of the discussion there.