search

gadicc / node-yahoo-finance2

Unofficial API for Yahoo Finance
https://www.npmjs.com/package/yahoo-finance2
MIT License
353 stars 58 forks source link

Deno support #685

Closed aslak01 closed 9 months ago

aslak01 commented 9 months ago

Feature Request

Wanted Feature

Hey, I was trying to set up a small Deno script to use this library with the recent import xxx from 'npm:xxx' addition. However it errors out on the request saying [Error] Errors { invalid_mapping, disallowed_character } (using the error handling from the docs). So I ported the script to Node just to check, and it works fine.

I'm looking at historical data at the moment so I tried the .chart and .historical modules, none of the others. Turns out it's not a great fit for me anyway since some of the historical stocks are missing from yahoo, but I thought I'd mention it.

Use Cases

I think being able to interface with deno would be a good addition to a project like this.

gadicc commented 9 months ago

Hey @aslak01... thanks for raising this! Would love Deno support out-the-box, but don't have the bandwidth to look at this at the moment. Going to leave open and mark as 'help wanted', and hope someone with suitable Deno experience can step in.

gadicc commented 9 months ago

And thanks also for opening the issue even though you might not be using it moving forward :sweat_smile: :pray:

z3nful commented 9 months ago

It looks like its a bug with deno. Using the workaround from the following issue allowed me to run it, but requires modifying one of the modules that deno uses:

https://github.com/denoland/deno/issues/19238

(Also, be careful if you copy paste the code from there, it has some odd blankspace formatting around the .'s)

aslak01 commented 9 months ago

Wow that's odd, especially since from that issue it appears to me that the issue was solved and patched. At least it's not a problem for this repo then.

z3nful commented 9 months ago

I think its a zombie bug deno is dealing with lol

I saw a few different posts from the last few years saying it was gone, but that it would come back after a few versions, almost all of them based around that TLD it currently fails on

aslak01 commented 9 months ago

Maybe you could make a new issue for them? Seems like you have a better understanding of the potential problem than I do.