gadicc / node-yahoo-finance2

Unofficial API for Yahoo Finance
https://www.npmjs.com/package/yahoo-finance2
MIT License
353 stars 58 forks source link

Refactored test sources. #714

Closed nocodehummel closed 7 months ago

nocodehummel commented 7 months ago

Closes #645.

Changes

Type

Comments/notes

The Node environment included test sources that caused invalid file references when building Nextjs v14 React-server-component(s). I moved the test sources to separate files. The changes build correctly and all test are passed on my local environment. I could not yet confirm that the dependent NextJs App also builds.

This is potentially a breaking change for dependent packages, which should also update the file reference to the Node test-environment.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (devel@c45623a). Click here to learn what that means.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## devel #714 +/- ## ======================================== Coverage ? 93.12% ======================================== Files ? 26 Lines ? 669 Branches ? 226 ======================================== Hits ? 623 Misses ? 46 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

gadicc commented 7 months ago

Hey @nordicgit70, thanks for this epic first-time contribution (and all your local testing). This is such a simple and straightforward workaround that I don't know why we didn't just go this route in the beginning :blush: This will be in the next release and there'll be an automated message here when that happens.

gadicc commented 7 months ago

:tada: This PR is included in version 2.9.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: