gadicc / node-yahoo-finance2

Unofficial API for Yahoo Finance
https://www.npmjs.com/package/yahoo-finance2
MIT License
395 stars 62 forks source link

Cookie Jar is a required param in `setGlobalConfig` #809

Closed Yhprum closed 1 month ago

Yhprum commented 1 month ago

Bug Report

Describe the bug

Argument of type '{ validation: { logErrors: false; }; }' is not assignable to parameter of type 'YahooFinanceOptions'. Property 'cookieJar' is missing in type '{ validation: { logErrors: false; }; }' but required in type '{ cookieJar: ExtendedCookieJar; logger?: Logger | undefined; }'.

Minimal Reproduction

yahooFinance.setGlobalConfig({ validation: { logErrors: false } });

Environment

Browser or Node: node Node version (if applicable): 20.9.0 Npm version: 10.1.0 Browser verion (if applicable): Library version (e.g. 1.10.1): 2.12.5

Additional Context

It used to be optional

gadicc commented 1 month ago

Thanks, @Yhprum! This has been fixed and will be in the next release. There'll be an automated message here when that happens.

gadicc commented 1 month ago

:tada: This issue has been resolved in version 2.13.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: