Peak detection for impl Float aka f64, f32, ...

gadomski / peakbag

Extract peaks from arrays of unsigned integers

http://gadomski.github.io/peakbag

MIT License

2 stars 0 forks source link

Peak detection for impl Float aka f64, f32, ... #1

Open 19h opened 4 years ago

19h commented 4 years ago

Hello @gadomski,

we have tried to use this library for the detection of local maxima in our signal data and quickly noticed your fairly strict constraint that all datatypes be unsigned.

What's the mathematical background of this limitation?

Thanks

gadomski commented 4 years ago

I wouldn't say there's a mathematical limitation as far as I can remember; I chose unsigned because this library was used for peak detection from amplitude data for lidar sensors, and those data are always unsigned. I'd be open to a pull request updating the datatypes to signed values.