Should delete_user_dbs() be transactional?

gae-init / gae-init-upload

Fork of gae-init with Google Cloud Storage

http://upload.gae-init.appspot.com

MIT License

36 stars 15 forks source link

Should delete_user_dbs() be transactional? #12

Closed mdxs closed 10 years ago

mdxs commented 10 years ago

Should delete_user_dbs() in main/user.py (of gae-init-upload) be marked with @ndb.transactional(xg=True) like it is done in the gae-init equivalent?

It seems that https://github.com/gae-init/gae-init/commit/80490fcd89914f7c12fc3929c3e4394ebd52cf29 applies, but I don't know why the decorator got lost towards gae-init-upload...

lipis commented 10 years ago

Sure.. my merge probably failed big time here..