search

gaearon / react-hot-boilerplate

Minimal live-editing example for React
MIT License
3.91k stars 879 forks source link

doesnt work #106

Closed watsonnnnn closed 7 years ago

watsonnnnn commented 7 years ago

can not work.I just clone the code and run it without changing anything.

mariuszdev commented 7 years ago

Works for me. I've pulled and launched master branch successfully. What do you mean by 'not work' ?

watsonnnnn commented 7 years ago

well , i did the same thing with you,and i have upgraded my npm just now.Now,i find it cant work in webstorm but can work in notepad++.i dont know why..

mariuszdev commented 7 years ago

Then I don't think it's problem with this repo.

mikelambert commented 7 years ago

Webstorm uses "safe writes", which break the change-detection logic. From another thread:

Disable "safe write" in Webstorm preferences - Appearance & Behavior / System Settings and on this page uncheck: Use "safe write""

joetidee commented 7 years ago

OMG - I have been tearing my hair our with the WEbpack config for 2 days and it has been WebStorm all along! Arrrghhh! (and thanks :)).

calesce commented 7 years ago

Yeah this looks like a Webstorm issue. Might be worth mentioning in the README.

calesce commented 7 years ago

the issue's now documented in the README. thanks!