search

gaearon / react-hot-boilerplate

Minimal live-editing example for React
MIT License
3.91k stars 879 forks source link

No error display with next branch? #123

Open zaynv opened 7 years ago

zaynv commented 7 years ago

When using the next branch of the boilerplate, I get no error display on the page when I add a syntax error to my component (although the error does show up in the console). When using the master branch, I do not have this issue. Was error reporting removed when switching to the next branch or is the branch not ready for use yet? Or am I just doing something wrong?

Steps to reproduce:

  1. Go to the next branch, click the Clone or download button, and then click Download ZIP.
  2. After unzipping the contents, run npm install, and then npm start.
  3. Go to the Counter.js file and change <h2>Counter: {this.state.counter}</h2> to <h2Counter: {this.state.counter}</h2>

As you can see, the error shows up in the console but there is no feedback on the page itself:

screen shot 2017-04-05 at 2 04 10 pm

When using the boilerplate from the master branch, I DO get feedback:

screen shot 2017-04-05 at 2 06 06 pm

Please let me know if I can provide any more information. Thanks very much.

zaynv commented 7 years ago

It looks like I just needed to add overlay: true to the devServer options in webpack.config.js. Should this be in there by default? If not, feel free to close this.