search

gaearon / react-hot-boilerplate

Minimal live-editing example for React
MIT License
3.91k stars 879 forks source link

webpack says nothing changed even when I added a line #20

Closed neerajsingh0101 closed 9 years ago

neerajsingh0101 commented 9 years ago

http://take.ms/0kfVz

I am using mac.

Is this because React should return only one element. If that is the case then ideally I should get an error in console.

I see the error in terminal. Just wanted to know if it is possible to indicate someway that "hey something went wrong. Look at log in terminal.".

neerajsingh0101 commented 9 years ago

If I use https://github.com/FrontendMasters/2015-02-13-React setup by @ryanflorence then I do get error message which is nice.

http://take.ms/7gCma

gaearon commented 9 years ago

This is because of NoErrorsPlugin in the config. You can remove it, but then HMR will break if you misspell an import. I'm not sure which is worse..

I'd like some kind of a middle solution here. Currently filed as https://github.com/webpack/webpack/issues/1105, so please track that issue if you're interested in the solution when/if it arrives.

gaearon commented 9 years ago

Remove NoErrorsPlugin and use React Hot Loader >= 1.3.0.

neerajsingh0101 commented 9 years ago

Thanks.