gaearon / react-hot-loader

Tweak React components in real time. (Deprecated: use Fast Refresh instead.)

http://gaearon.github.io/react-hot-loader/

MIT License

12.26k stars 801 forks source link

Not compatible with loadable-components? #1361

Open harrisonlo opened 5 years ago

harrisonlo commented 5 years ago

As reported in https://github.com/smooth-code/loadable-components/issues/243 react-hot-loader doesn't seem to be "compatible" with loadable-components, there needs to be multiple hot() where code-splitting is used.

Is this known and intended? If so, please update the README and remove loadable-components as a "compatible" lib. Else, please fix this issue :) A reproducible demo is in the linked issue above.

Thank you!

theKashey commented 5 years ago

Loadable-components are not compatible with RHL, that's true, as long as they are not re-importing updated module.

Probably it's better to reevaluate this - the current version of React Universal Component might be also not compatible with RHL.

1339, if ever got implemented, should solve it.