Open magicdawn opened 4 years ago
source
import SomeWorker from './some.worker.js' // via worker-loader import * as comlink from 'comlink' const someWorker = comlink.wrap(new SomeWorker())
generated js
reactHotLoader.register(someWorker, blabla)
What you are reporting: the register body try to get some props on someWorker, produced by comlink.wrap it's a Proxy. and errors like
register
comlink.wrap
Proxy
someWorker.name
comlink.expose(obj)
obj.name[Symbol.toPrimitives]()
be smart, don't wrap everything
the babel plugin is register ing all identifiers
React Hot Loader version:
does not matter.
tried cold, that does not prevent reactHotLoader.register() code
cold
reactHotLoader.register()
Easy to reproduce 👍, I'll handle it.
Description
source
generated js
What you are reporting: the
register
body try to get some props on someWorker, produced bycomlink.wrap
it's aProxy
. and errors likeregister
logic wantssomeWorker.name
comlink.expose(obj)
, comlink callobj.name[Symbol.toPrimitives]()
Expected behavior
be smart, don't wrap everything
Actual behavior
the babel plugin is
register
ing all identifiersEnvironment
React Hot Loader version:
does not matter.