search

gaearon / react-side-effect

Create components whose nested prop changes map to a global side effect
MIT License
1.22k stars 75 forks source link

Memory Leak on Server Render? #39

Closed danmakenoise closed 7 years ago

danmakenoise commented 7 years ago

When analyzing our heaps on our server, the array mountedInstances gets larger and larger with each check, even with manually triggering garbage collection. This eventually takes up a LOT of memory.

We are currently using react-document-title within our isomorphic components, which in turn uses this library.

When we are on the server, it seems like we shouldn't need to keep track of mounted instances at all, right? Is that within the scope of this library to handle, or should we be accounting for this in our implementation?

Happy to help work on solution, just wanted to see if you think this is an issue with the library or not.

danmakenoise commented 7 years ago

Closing this as the problem is clearly addressed in the README! Nevermind!