search

gaearon / redux-devtools-log-monitor

The default monitor for Redux DevTools with a tree view
MIT License
310 stars 67 forks source link

Can you please move "styles" into the props #8

Closed EvHaus closed 8 years ago

EvHaus commented 8 years ago

@gaearon You mentioned in another another issue that the reason you're using inline styles vs. CSS classes is because you think it's easy enough to clone the LogMonitor to make theming changes.

However, there are two big reasons why cloning the LogMonitor as a theming tool is a pain at the moment:

1) It forks the code. So no new updates to the main LogMonitor code base will not be pulled in anymore. 2) It's actually quite a lot of steps to clone the LogMonitor. It requires copying the code (for all the nested components), installing all the required required dependencies, rebuilding the app, etc...

It's a big effort when all you want to do is make the font-size 1px smaller.

Would you consider moving the "styles" into a prop instead so at least the inline styles can be overwritten?

gaearon commented 8 years ago

Maybe we can use something like https://github.com/prometheusresearch/react-stylesheet to make them configurable?

EvHaus commented 8 years ago

Sure that would work, or just use CSSmodules instead https://github.com/css-modules/css-modules

gaearon commented 8 years ago

The reason I don’t want to do this is this makes every internal style change a breaking change. Since we follow semver, we don’t want to break people all the time, or to increment majors on every version.