search

gaearon / subliminal

An opinionated minimalistic VS Code theme for JavaScript
https://marketplace.visualstudio.com/items?itemName=gaearon.subliminal
MIT License
631 stars 25 forks source link

TypeScript support, Demo files and separate italic theme #21

Open tobiastimm opened 6 years ago

tobiastimm commented 6 years ago

In my last PR #5 I've added TypeScript support to subliminal.

In this PR I have done some refactoring

TypeScript before ts before

TypeScript after ts before

The screens are based on the Subliminal Operator theme. In the original theme the italic style style is kept to a minimum.

Fixes #19 #4

EDIT:

TypeScript ts / tsx subliminal-actual-tsx

HTML before subliminal_html_before

HTML after subliminal_html_after

tobiastimm commented 6 years ago

@gaearon @palashmon

Would be cool if one of you guys could review it 😄

palashmon commented 6 years ago

Looks good to me :+1:

tobiastimm commented 6 years ago

@gaearon Hey Dan, any chance that we can merge this for TypeScript support?

adriantoine commented 6 years ago

That would be great, is there a way to test this specific branch locally?

tobiastimm commented 6 years ago

@adriantoine you can clone my fork via git into your .vscode/extensions folder. Make sure to uninstall your subliminal version first

adriantoine commented 6 years ago

@tobiastimm well I ended up using your theme Raiju, thanks!

GlennSmeulders commented 6 years ago

Very nice, thank you @tobiastimm

EDIT: @tobiastimm would it be possible to add a color for type assignment perhaps?

For example: ids: string[] so we highlight string[]

tobiastimm commented 6 years ago

@GlennSmeulders sry I'm not working on this anymore :/

tobiastimm commented 6 years ago

@GlennSmeulders see https://twitter.com/TbsTimm/status/1011895476231262209 . Support also available for the subliminal variant

andrasnyarai commented 4 years ago

it would be niice