search

gaearon / subliminal

An opinionated minimalistic VS Code theme for JavaScript
https://marketplace.visualstudio.com/items?itemName=gaearon.subliminal
MIT License
631 stars 25 forks source link

the color of the bar now allows you to see the errors, etc. #3

Open jerolan opened 6 years ago

jerolan commented 6 years ago

The transparency of the bar in contrast to the background of the scroll did not allow me to see the errors and other markers of the editor when the bar is on that section

Before screen shot 2018-04-30 at 4 58 28 pm

After screen shot 2018-04-30 at 4 58 18 pm

gaearon commented 6 years ago

Thanks for the PR!

I see the reasoning. Personally I don't use this feature so this isn't a dealbreaker to me.

I made the scrollbar have the color of the background because I didn't find any way to hide an inactive scrollbar completely. That's what I really wanted but Code doesn't seem to allow that (or is there a way?)

So making it opaque is a hack but I need it to reduce the noise. If you find a proper way to hide the scrollbar please let me know and I'll merge that.

I'll keep the PR open in case somebody else finds this valuable (e.g. as an override).