Support for more italic style & TypeScript .ts / .tsx

gaearon / subliminal

An opinionated minimalistic VS Code theme for JavaScript

MIT License

631 stars 25 forks source link

Closed tobiastimm closed 6 years ago

tobiastimm commented 6 years ago

Fixes #4

palashmon commented 6 years ago

First of all thanks for this PR. Could you please share some before and after screenshots for .ts/.tsx file support.

This also closes #19

tobiastimm commented 6 years ago

Before subliminal-before-tsx After subliminal-after-tsx

It is still not 100% optimal, but I'm completely new to vscode theming, maybe some other people have some ideas or improvements.

tobiastimm commented 6 years ago

I've removed the italic style on the punctuation. Was kinda annoying for me

Before punctuation-change_before

After punctuation-change_after

tobiastimm commented 6 years ago

I will close this PR and create a new one, because I've reworked my fork quite a bit.