search

gael-ian / vagrant-bindfs

A Vagrant plugin to automate bindfs mount in the VM
MIT License
483 stars 37 forks source link

Rewrite welcome? #13

Closed tboerger closed 10 years ago

tboerger commented 10 years ago

Are you open for a rewrite/refactoring for the current vagrant plugin API? I would create a pull request for that including more capabilities for other distros. The other thing i would like to change is that i will replace the dashes in the options with underscores to make it valid symbols.

What do you think about it?

igor47 commented 10 years ago

more capabilities sounds awesome. changing the name of the options sounds like it would make things difficult for current users, who would need to edit their Vagrantfiles. i wouldn't mind any changes that don't affect users, for instance if both dashes and underscores remained valid.

also, nice penguin!

tboerger commented 10 years ago

I would recommend to integrate the underscore options and to integrate some kind of deprecation message for the other options. I will check the caps for ubuntu, debian, openSUSE/SLES and maybe i get some hints for Archlinux.

tboerger commented 10 years ago

I asked on vagrant itself if it makes sense to integrate this functionality into the core directly related to NFS before i found this here :)

gael-ian commented 10 years ago

Help is always welcome :) Thanks.

Options available in vagrant-bindfs mimic those supported by BindFS when the plugin was writed first. I choosed this to not confuse users of the plugin as options documentation is just a link to the BindFS doc but you're right, it's not really fluent if you are used to ruby.

The plugin does not fully support neither shortands nor new options introduced by later bindFS releases.

It's been a while since I start to think to rewrite this part of the plugin to introduce an option translator that will accept all options in both short and long form and normalize them for the command build. Maybe this translator can also support notations with dash and underscore.

tboerger commented 10 years ago

Looks fine with https://github.com/gael-ian/vagrant-bindfs/pull/14 :)