search

gaelcolas / DscInfraSample

A Control Repo for a DSC Infrastructure as Code
MIT License
47 stars 22 forks source link

added 'Role' parameter to build only for a certain role #14

Closed DeBasti closed 6 years ago

DeBasti commented 6 years ago

Hi there,

I added a parameter in order to build the mof- and meta mof files only for a certain role.

Greetings, Sebastian

raandree commented 6 years ago

Would it be better to have a Filter parameter that allows the user to select the node based on whatever is important? There are many more options you might want to filter on, like Country, Domain, etc.

gaelcolas commented 6 years ago

Thanks for the PR, much appreciated!

Filtering by node is already supported (but undocumented), using the parameter $FilterNode. This needs to be added to the .build.ps1 parameters should you wish to use it.

Whether a role filter should be present is a different question. What's the use case and why? When do you use it? What's the value?

It's not a bad idea, but I'd like to understand the underlying reasons.

The DSCInfraSample is just an example control repo that people should customise to their taste, and that's a great example anyway.

raandree commented 6 years ago

The use case is that you want to build only a subset of nodes. Imagine you have some thousand nodes and the change to the config is affecting only some nodes that you want to build the MOFs for. Especially in dev and test this could speed things up.

To have the max flexibility I would vote for a FilterScript parameter so the use case is not fixed.

gaelcolas commented 6 years ago

Yep, I was thinking the same. It should be a -Filter parameter...

On Mon, 23 Apr 2018, 11:10 Raimund Andrée [MSFT], notifications@github.com wrote:

The use case is that you want to build only a subset of nodes. Imagine you have some thousand nodes and the change to the config is affecting only some nodes that you want to build the MOFs for. Especially in dev and test this could speed things up.

To have the max flexibility I would vote for a FilterScript parameter so the use case is not fixed.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/gaelcolas/DscInfraSample/pull/14#issuecomment-383524437, or mute the thread https://github.com/notifications/unsubscribe-auth/AIjANVdFY_SUOOs9o5IxlPGeTyIWtqpTks5traiLgaJpZM4TeEt0 .

DeBasti commented 6 years ago

You've got a point there. I implemented the filter parameter today (it's not yet pushed though). How is the usual procedure? Closing this pull request and raising a new one?

gaelcolas commented 6 years ago

If you made the change in the same branch, yes. Otherwise you can keep open and create new PR. Please make sure you git pull --rebase from master.