search

gaelcolas / Sampler

Module template with build pipeline and examples, including DSC elements.
MIT License
171 stars 42 forks source link

Missing property `BuiltModuleSubdirectory` in template for build.yml #368

Open johlju opened 2 years ago

johlju commented 2 years ago

This property should be removed as it does not do anything (no code support it):

https://github.com/gaelcolas/Sampler/blob/d19ef072498ac9df81a3839b0b7a502a066f2235/Sampler/Templates/Build/build.yaml.template#L11

Instead we should add the property BuiltModuleSubdirectory:

BuiltModuleSubdirectory: builtModule
gaelcolas commented 2 years ago

OutputDirectory is used, but I agree that BuiltModuleSubdirectory: should be there too. Actually, it should be the default IMO. Will send a PR for that.

johlju commented 2 years ago

OutputDirectory is used as a variable in the task, but if set in build.yaml it is never fetch by any code, at least not what I could find.

gaelcolas commented 2 years ago

Correct, it's only the build.ps1 parameter. https://github.com/gaelcolas/Sampler/blob/main/build.ps1#L80