gaelcolas / Sampler

Module template with build pipeline and examples, including DSC elements.
MIT License
172 stars 42 forks source link

Fixes #384 #385

Closed raandree closed 2 years ago

raandree commented 2 years ago

Pull Request

This PR fixes #384.

Pull Request (PR) description

Fixed

Task list


This change is Reviewable

codecov[bot] commented 2 years ago

Codecov Report

Merging #385 (c4a3b0b) into main (138e817) will decrease coverage by 0%. The diff coverage is 75%.

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #385   +/-   ##
===================================
- Coverage    81%    81%   -1%     
===================================
  Files        41     41           
  Lines      2224   2225    +1     
===================================
  Hits       1807   1807           
- Misses      417    418    +1     
Impacted Files Coverage Δ
.build/tasks/Create_Release_Git_Tag.build.ps1 65% <75%> (-2%) :arrow_down:
johlju commented 2 years ago

$null in my suggested snippet should not be necessary.

gaelcolas commented 2 years ago

@raandree whenever you're back from vacation, please look at this :) You'll need to rebase and force push first, thanks :)

raandree commented 2 years ago

I have just done the rebase.