gaelcolas / Sampler

Module template with build pipeline and examples, including DSC elements.

MIT License

171 stars 42 forks source link

Fixes #384 #385

Closed raandree closed 2 years ago

raandree commented 2 years ago

Pull Request

This PR fixes #384.

Pull Request (PR) description

Fixed

Fixed #384: It not tag is defined, Create_Release_Git_Tag throws an error.

Task list

[x] The PR represents a single logical change. i.e. Cosmetic updates should go in different PRs.
[x] Added an entry under the Unreleased section of in the CHANGELOG.md as per format.
[x] Local clean build passes without issue or fail tests (build.ps1 -ResolveDependency).
[ ] Documentation added/updated in README.md.
[ ] Comment-based help added/updated.
[ ] Localization strings added/updated in all localization files as appropriate.
[ ] Unit tests added/updated. See DSC Community Testing Guidelines.
[ ] Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
[x] New/changed code adheres to DSC Community Style Guidelines.

This change is

codecov[bot] commented 2 years ago

Codecov Report

Merging #385 (c4a3b0b) into main (138e817) will decrease coverage by 0%. The diff coverage is 75%.

@@         Coverage Diff         @@
##           main   #385   +/-   ##
===================================
- Coverage    81%    81%   -1%     
===================================
  Files        41     41           
  Lines      2224   2225    +1     
===================================
  Hits       1807   1807           
- Misses      417    418    +1

Impacted Files	Coverage Δ
.build/tasks/Create_Release_Git_Tag.build.ps1	`65% <75%> (-2%)`	:arrow_down:

johlju commented 2 years ago

$null in my suggested snippet should not be necessary.

gaelcolas commented 2 years ago

@raandree whenever you're back from vacation, please look at this :) You'll need to rebase and force push first, thanks :)

raandree commented 2 years ago

I have just done the rebase.