gaelcolas / Sampler

Module template with build pipeline and examples, including DSC elements.
MIT License
172 stars 42 forks source link

Fixing code style `module.tests.ps1` #396

Closed raandree closed 2 years ago

raandree commented 2 years ago

Pull Request

Pull Request (PR) description

This PR almost only applies this project's code style rules to the file \tests\QA\module.tests.ps1. The only functional change is making use of the variable $ProjectName instead of using the hard coded name Sampler.

The file \Sampler\Templates\Sampler\module.tests.ps1.template was synced with \tests\QA\module.tests.ps1 as the file module.tests.ps1.template still used the Pester 4 syntax and simply does not work with new modules.

Task list


This change is Reviewable

codecov[bot] commented 2 years ago

Codecov Report

Merging #396 (ae5558c) into main (5640e43) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #396   +/-   ##
===================================
  Coverage    81%    81%           
===================================
  Files        41     41           
  Lines      2225   2225           
===================================
  Hits       1807   1807           
  Misses      418    418           
gaelcolas commented 2 years ago

Thanks, updated your branch. Waiting for build to work before merging but it looks good. The changelog entry could be clearer though...