gaelcolas / Sampler

Module template with build pipeline and examples, including DSC elements.

MIT License

171 stars 42 forks source link

feat: Add support for publishing NuGet package with .NET SDK #434

Closed pshamus closed 1 year ago

pshamus commented 1 year ago

Pull Request

Pull Request (PR) description

Adds support for publishing a NuGet package with the .NET SDK, if installed.

Fixes 433.

Task list

[x] The PR represents a single logical change. i.e. Cosmetic updates should go in different PRs.
[x] Added an entry under the Unreleased section of in the CHANGELOG.md as per format.
[x] Local clean build passes without issue or fail tests (build.ps1 -ResolveDependency).
[ ] Documentation added/updated in README.md.
[ ] Comment-based help added/updated.
[ ] Localization strings added/updated in all localization files as appropriate.
[x] Unit tests added/updated. See DSC Community Testing Guidelines.
[ ] Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
[x] New/changed code adheres to DSC Community Style Guidelines.

This change is

codecov[bot] commented 1 year ago

Codecov Report

Merging #434 (125de7f) into main (73c8777) will increase coverage by 0%. The diff coverage is 100%.

@@         Coverage Diff         @@
##           main   #434   +/-   ##
===================================
  Coverage    81%    81%           
===================================
  Files        44     44           
  Lines      2319   2326    +7     
===================================
+ Hits       1899   1906    +7     
  Misses      420    420

Impacted Files	Coverage Δ
.build/tasks/release.module.build.ps1	`82% <100%> (+<1%)`	:arrow_up:

pshamus commented 1 year ago

@gaelcolas How can I mock a nonexistent command? I need to be able to test the task condition of when one of the executables does not exist on the system.

Edit: I figured it out but the CI builds are still failing for some other reason. Any hints? It builds locally just fine.

gaelcolas commented 1 year ago

Looks like a pester issue, maybe introduced in the latest release? Try pinning an older version of pester in RequiredModules.psd1

pshamus commented 1 year ago

Looks like a pester issue, maybe introduced in the latest release? Try pinning an older version of pester in RequiredModules.psd1

Yeah, seems to pass with Pester 5.4.1.

johlju commented 1 year ago

I merged a change to the tests, so we can revert back to Pester 5.5 again. It should pass now.

pshamus commented 1 year ago

Rebased and pushed an updated commit.

gaelcolas commented 1 year ago

Thank you thank you. :)