gaelcolas / Sampler

Module template with build pipeline and examples, including DSC elements.
MIT License
171 stars 42 forks source link

Refactor `PSResourceGet` implementation in `Resolve-Dependency.ps1` #450

Closed jimbrig closed 10 months ago

jimbrig commented 11 months ago

Refactor Resolve-Dependency.ps1 for new PSResourceGet Implementation

Description



This change is Reviewable

codecov[bot] commented 11 months ago

Codecov Report

Merging #450 (0fd09e6) into main (9158f6d) will decrease coverage by 8%. Report is 1 commits behind head on main. The diff coverage is n/a.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/gaelcolas/Sampler/pull/450/graphs/tree.svg?width=650&height=150&src=pr&token=xHbQB1FHYN&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Gael)](https://app.codecov.io/gh/gaelcolas/Sampler/pull/450?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Gael) ```diff @@ Coverage Diff @@ ## main #450 +/- ## ==================================== - Coverage 81% 74% -8% ==================================== Files 44 13 -31 Lines 2326 1500 -826 ==================================== - Hits 1902 1118 -784 + Misses 424 382 -42 ``` [see 31 files with indirect coverage changes](https://app.codecov.io/gh/gaelcolas/Sampler/pull/450/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Gael)
johlju commented 11 months ago

@jimbrig please also update the CHANGELOG's unreleased section for the build to pass.

johlju commented 10 months ago

This was resolved in another PR. Thanks for contributing!

jimbrig commented 8 months ago

@johlju apologies just now seeing this (GitHub notifications got bombozzled with dependabot...) but glad to see it ended up getting resolved. Thanks!