gaelcolas / Sampler

Module template with build pipeline and examples, including DSC elements.
MIT License
167 stars 42 forks source link

Fix bug when `$ChocolateyBuildOutput` is null or empty string #454

Closed johlju closed 8 months ago

johlju commented 8 months ago

Pull Request

Pull Request (PR) description

After a few hours debugging in DscResource.DocGenerator I found that it was this bug that cause the other variables not to be set to correct values, or no mocks was hit as I was expecting. ๐Ÿ™‚ Now off to holiday celebration. ๐ŸŽ„

Fixed

Task list


This change isโ€‚Reviewable

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9158f6d) 81% compared to head (3ac37bf) 81%. Report is 1 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/gaelcolas/Sampler/pull/454/graphs/tree.svg?width=650&height=150&src=pr&token=xHbQB1FHYN&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Gael)](https://app.codecov.io/gh/gaelcolas/Sampler/pull/454?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Gael) ```diff @@ Coverage Diff @@ ## main #454 +/- ## =================================== Coverage 81% 81% =================================== Files 44 44 Lines 2326 2328 +2 =================================== + Hits 1902 1904 +2 Misses 424 424 ``` | [Files](https://app.codecov.io/gh/gaelcolas/Sampler/pull/454?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Gael) | Coverage ฮ” | | |---|---|---| | [Sampler/scripts/Set-SamplerTaskVariable.ps1](https://app.codecov.io/gh/gaelcolas/Sampler/pull/454?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Gael#diff-U2FtcGxlci9zY3JpcHRzL1NldC1TYW1wbGVyVGFza1ZhcmlhYmxlLnBzMQ==) | `91% <100%> (+<1%)` | :arrow_up: |
johlju commented 8 months ago

Merging this so I can continue working in DscResource.DocGenerator.