Closed Sidoran closed 7 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 81%. Comparing base (
5c10447
) to head (54a945c
).
Also if there are a module project in the root of TestSampler, and there is a module project in a the subfolder SecondModule
This scenario might be difficult to determine without scanning each subfolder 🤔 So maybe for this case we just document that it is not recommended to have a module project in the root folder at the same time as having module projects in subfolders. 🤔
Hi @johlju, TY for paying attention to this issue. Modifying several modules simultaneously in one multi-module repo is not a good idea, but the code should support it. I changed the code, and from now each module folder will be checked separately.
About the second case (The repo with the module in root and the other module in a subfolder). It would be tough to divide which module file is related (to the root level or the module in a subfolder). I am inclined not to support the given type of multi-module repo to not deeper into a folder structure and all other items. I would happily update the documentation with the info that a given type of repo may generate false positive errors. Can you please point me to where I can add this info?
I would happily update the documentation with the info that a given type of repo may generate false positive errors. Can you please point me to where I can add this info?
Suggest adding a new section under https://github.com/gaelcolas/Sampler/blob/main/README.md#how-to-create-a-new-project
The Readme.md file has been updated with the multi-module repository information.
Pull Request
Pull Request (PR) description
Fixed
Task list
build.ps1 -ResolveDependency
).This change is