Closed dan-hughes closed 7 months ago
@johlju, as per ActiveDirectoryDSC.
Just a note, I could only get this to build using PS7. 5.1 failed with a file encoding issue with Sampler.psd1
having a BOM.
Also, I didn't know if I needed to bump the version in the plasterManifest.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 81%. Comparing base (
5b43dd8
) to head (8ab9415
).
5.1 failed with a file encoding issue with Sampler.psd1 having a BOM.
No file should have BOM. Do you mean the file in the repo is UTF with BOM, because I can't see it? π€
I didn't know if I needed to bump the version in the plasterManifest.
I have never done that, didn't even know there were a version in there π
5.1 failed with a file encoding issue with Sampler.psd1 having a BOM.
No file should have BOM. Do you mean the file in the repo is UTF with BOM, because I can't see it? π€
It was in the output directory. I'm not too bothered, it it passes with PS7.
Ah, never checked the output directory when running 5.1 honestly so that has probably gone by unnoticed. Let's ignore that for now. π
Pull Request
Pull Request (PR) description
Add extensions.json to add recommended extensions.
Added
Added extensions.json for vscode
build.ps1 -ResolveDependency
).This change isβ