gaelcolas / Sampler

Module template with build pipeline and examples, including DSC elements.
MIT License
172 stars 42 forks source link

Template - VSCode: Add extensions.json #469

Closed dan-hughes closed 7 months ago

dan-hughes commented 7 months ago

Pull Request

Pull Request (PR) description

Add extensions.json to add recommended extensions.

Added

dan-hughes commented 7 months ago

@johlju, as per ActiveDirectoryDSC.

Just a note, I could only get this to build using PS7. 5.1 failed with a file encoding issue with Sampler.psd1 having a BOM.

Also, I didn't know if I needed to bump the version in the plasterManifest.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81%. Comparing base (5b43dd8) to head (8ab9415).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/gaelcolas/Sampler/pull/469/graphs/tree.svg?width=650&height=150&src=pr&token=xHbQB1FHYN&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Gael)](https://app.codecov.io/gh/gaelcolas/Sampler/pull/469?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Gael) ```diff @@ Coverage Diff @@ ## main #469 +/- ## =================================== Coverage 81% 81% =================================== Files 44 44 Lines 2328 2328 =================================== Hits 1904 1904 Misses 424 424 ```
johlju commented 7 months ago

5.1 failed with a file encoding issue with Sampler.psd1 having a BOM.

No file should have BOM. Do you mean the file in the repo is UTF with BOM, because I can't see it? πŸ€”

johlju commented 7 months ago

I didn't know if I needed to bump the version in the plasterManifest.

I have never done that, didn't even know there were a version in there πŸ˜ƒ

dan-hughes commented 7 months ago

5.1 failed with a file encoding issue with Sampler.psd1 having a BOM.

No file should have BOM. Do you mean the file in the repo is UTF with BOM, because I can't see it? πŸ€”

It was in the output directory. I'm not too bothered, it it passes with PS7.

johlju commented 7 months ago

Ah, never checked the output directory when running 5.1 honestly so that has probably gone by unnoticed. Let's ignore that for now. 😊