search

gaelmarhic / Quadrant

A Gradle plugin for Android that makes navigation easy in multi-module projects.
Apache License 2.0
216 stars 13 forks source link

feat: create FQCN with module namespace #16

Closed MasaHirano closed 8 months ago

MasaHirano commented 10 months ago

Overview

Quadrant supports partially qualified class names by extracting package names from AndroidManifest.xml (ref: #3). However, the package attribute was deprecated in the Android Gradle Plugin (AGP) 7.3.0. Also, in the AGP 8.0.0, the namespace becomes a required parameter.

This PR aims to keep supporting partially qualified class names by retrieving namespace property from an Android extension.

If you want to check how these changes behave in an app, I recommend using my sample project https://github.com/alpaca0984/QuadrantKspCompileSample. It uses AGP 8.0.0 and imports this Quadrant plugin.

References

gaelmarhic commented 10 months ago

Thanks for the PR @alpaca0984! I will try to review it ASAP (now sure when though, because of the holidays).

MasaHirano commented 10 months ago

I wish you a wonderful Christmas time, gaelmarhic 🎄

gaelmarhic commented 10 months ago

Thanks a lot @alpaca0984! I wish you a wonderful Christmas too :)

gaelmarhic commented 8 months ago

@alpaca0984 I have tested the PR as well as generated and published a new version. Here goes: https://github.com/gaelmarhic/Quadrant/releases/tag/v1.9 https://plugins.gradle.org/plugin/com.gaelmarhic.quadrant/1.9 Thanks again for your contributions! :)

MasaHirano commented 8 months ago

Hi @gaelmarhic , I hope you had a great vacation :) Thank you for the publication. I added it to my project and... found an issue. Now, the extension configuration doesn't work. I know what is going wrong. Will open a follow-up PR soon

gaelmarhic commented 8 months ago

Hi @alpaca0984 , I had a great holidays, thanks. :) Great catch!