Support activity partially qualified class names

IslamSalah commented 3 years ago

Overview:

This plugin adds a tangible benefit for multi-module navigation. With relaxing some constrains it can be even easier to use. Especially for big-sized teams where applying constrains can add some friction. Currently the plugin fails the build with guiding error on breaking the FQCN constraint. On relaxing this constrains, things go smoother and siliently pass CC @gaelmarhic

Type of change:

Feature

What's the purpose of this PR?

Extend the plugin capability to handle both partially & fully qualified class names for manifest files defined activities

What's the impact of this PR?

Support partially qualified class names

<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.poc.bookingfeature">

<application>
    <activity android:name=".BookingActicity" />
...

Retain support for fully qualified class names

<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.poc.bookingfeature">

<application>
    <activity android:name="com.poc.bookingfeature.BookingActicity" />
...

_{N.B commit by commit review can be helpful}

gaelmarhic commented 3 years ago

Thanks so much for your contribution @IslamSalah ! I have quite a busy week, but I will definitely have a look at it this week-end and get back to you! Cheers :)

IslamSalah commented 3 years ago

Thank you for the review, should we expect a new release soon?

gaelmarhic commented 3 years ago

Just released version 1.5 including this change: https://github.com/gaelmarhic/Quadrant/releases https://plugins.gradle.org/plugin/com.gaelmarhic.quadrant Let me know how it goes and thanks again ;)

gaelmarhic / Quadrant