gzip: invalid option -- 'z' when running command 'hostsblock' and 'hostsblock-urlchecker'

gaenserich / hostsblock

an ad- and malware-blocking script for Linux

https://github.com/gaenserich/hostsblock

225 stars 28 forks source link

gzip: invalid option -- 'z' when running command 'hostsblock' and 'hostsblock-urlchecker' #34

Closed maniqui closed 9 years ago

maniqui commented 9 years ago

Hi. It seems that everywhere the gzip command is used, there is a -z parameter passed along, which makes it fail. The consequences are that the hostsblock.db.gz isn't created properly and then, other commands fail too.

The fix is pretty straightforward: remove the -z parameter. BTW, the -z parameter is also used with the command pigz (parallel gzip), but as I don't use that program, I'm not sure if this issue affects it too. I'd guess it does.

gaenserich commented 9 years ago

fixed! 5762f2bd7f6597db47a1d6f3e998694058217c34

maniqui commented 9 years ago

There are still some places in hostsblock-common.sh where the incorrect -z (for gzip) is being used:

Lines: #L228 #L289 #L313

Sadi58 commented 9 years ago

@maniqui : I can't see any remaining "-z" option (at least in the files here in git repository), are you sure you haven't confused it with "-dc" which seems valid?