search

gaenserich / hostsblock

an ad- and malware-blocking script for Linux
https://github.com/gaenserich/hostsblock
225 stars 28 forks source link

Change to setfacl rather than adding groups & add dnsmasq reloader #74

Closed Salothin closed 7 years ago

Salothin commented 7 years ago

Just for hardening and making dnsmasq reloads easier.

It would probably be a better idea to install the reloader only if the user is running dnsmasq.

Salothin commented 7 years ago

Yeah I missed that hostsblock-urlcheck needs a reload too, I guesssystemctl reload dnsmasq could be added to sudoers, both the main script and -c can call systemctl reload dnsmasq, this way the proposed reload service file -reload_dnsmasq.service- and the modification to the hostsblock service file may be ommited.

About the acl, yep, I missed that too. The directory would need some setup also, and reapplying as you said.

So only the reload service may help. The pull should be polished and discussed more.