search

gaetano-guerriero / pypjlink

PJLink is a standard for controlling data projectors.
Apache License 2.0
10 stars 16 forks source link

Misinformation in the "Python library usage" documentation section #2

Open RomanMeR opened 7 years ago

RomanMeR commented 7 years ago

Hello gaetano-guerriero, today I just started using pypjlink and found out that command line utility works fine for my Vivitek projector, but when I tried using Python library, it raises assert in the protocol.py, in the parse_response function, on the "assert header == '%'" line. After spending some time I understood that the difference between command line interface and the way I used library is that CLI calls "authenticate" method on Projector instance before issuing command requested by user. But the "Python library usage" section in documentation both on GitHub and PyPi says nothing about this. So it would be great to fix the "Python library usage" documentation section and mention the "authenticate" call in it.

ozel commented 7 years ago

thank's for writing this down. I can confirm the behaviour you describe with a Mitsubishi projector. Calling of .authenticate() is needed always, even if no password is set.

Gummibeer commented 7 years ago

I've opened a PR https://github.com/gaetano-guerriero/pypjlink/pull/3 to fix this and some other small issues in the readme.