Open LeeThompson opened 1 year ago
If you use it like this:
function load($url, $DEBUG, $consoleMode = false, $timeOut = 60) {
if (function_exists('curl_version')) {
$timeOut = getGlobal('curl_timeout');
if (!isset($timeOut )) { $timeOut = 60; }
$timeOut = getGlobal('curl_timeout');
is already set before the function call, so I would implement it like this:
function load($url, $DEBUG, $consoleMode = false, $timeOut = 60) {
if (function_exists('curl_version')) {
if (!isset($timeOut )) { $timeOut = 60; }
It's being used by the fallback (non curl) as well, but I'm restructuring it a bit. The above is just a quick fix.
I will be happy with every update-request and promise to merge it ASAP ;-)
I'll see if I can do a special branch for this hotfix. My main branch is in the middle of some major rework (including supporting a config file).
Nevermind, it looks like you got it, that should be enough for now! :)
No Stress, we can do it all in one Step if you like
I'm using #9 for my working on list.
There is a bug (my fault) where the curl timeout isn't being set properly, this will cause it to hang instead of timing out.
I have fixed it locally but I've changed other things as well and not ready for a PR.
Quick fix is to insert the following two lines in the
load
functionCurrent:
Hot Fix:
(It's handled much better in the newer code)