gaffner / PyBitTorrent

MIT License
5 stars 2 forks source link

Major changes in the code #27

Open wLxCvcY20V opened 6 months ago

wLxCvcY20V commented 6 months ago

I've been thinking in making some major changes in the code before implementing new features and fixing some issues that I found. Here are my ideas:

Issues that I found:

Note that I'm not much familiar with dealing with binary files and raw protocol responses. But I will give it a read to continue expanding the project.

Let me know what you think.

gaffner commented 6 months ago

That's sound awesome! If you can make this changes and fixing the issues you found, it will be great. The current structure of the project it is bit "messy" - it should be organized in folders for each class, even if this folder will contain only one file. Your changes sounds very useful - go for it.

I made you collaborator to this project, so you can now commit directly to the project (its better to do them in new branch,in this format: feature/XXX-XXX-XX, and then make merge request to main and put me as reviewer).

@Sprooty if you have any opinion regarding this feel free to share :)

gaffner commented 6 months ago

Any new? :)

wLxCvcY20V commented 6 months ago

@gaffner Right now I'm with some connection issues, I'll probably have to switch my current provider. Currently, I only have access to mobile network.