search

gaffneyc / sunspot-queue

Background search indexing using existing worker systems
MIT License
35 stars 37 forks source link

Optional dependencies for sidekiq/resque #7

Closed cheald closed 11 years ago

cheald commented 11 years ago

Would it be possible to change resque and sidekiq to optional dependencies, rather than runtime dependencies? Currently, including sunspot-queue includes both the resque and sidekiq gems in your bundle, since it says it depends on both of them. Since the user has to specify which backend they want to use anyhow, why require those as hard dependencies?

gaffneyc commented 11 years ago

@cheald That's a bit of a surprise, I thought runtime dependencies were optional but I tested it out and both rubygems and bundler will install any runtime dependencies along side any dependencies. Weird there are two different syntaxes for the exact same functionality.

I'm thinking the only way to get around it is to make them development dependencies which will work more as intended.

cheald commented 11 years ago

Thank you! (And yes, it is confusing!)