Any other possible way to use this gem for sunspot_rails 1.1.0 ?

gaffneyc / sunspot-queue

Background search indexing using existing worker systems

MIT License

35 stars 37 forks source link

Any other possible way to use this gem for sunspot_rails 1.1.0 ? #9

Closed umamahe closed 11 years ago

umamahe commented 11 years ago

Any other possible manner to use this gem for sunspot_rails 1.1.0 ?

gaffneyc commented 11 years ago

I haven't tested it with 1.1.0 but it may just require a change to the gemspec. If I pushed a change to a branch would you be able to test it with your application?

gaffneyc commented 11 years ago

@umamahe I did a quick look at it. We don't depend on any railsisms but the index jobs use the ActiveModel API in a couple spots and sunspot_rails 1.1.0 appears to be Rails 2.3.

It should be possible to change the gemspec to 1.1.0 and modify the jobs to work with the 2.3 api but it's not something I'm interesting in maintaining. Rails 2.3 has been end-of-life for a while and sunspot 1.1.0 was released almost 3 years ago.

If you want to fork the code and use it with sunspot 1.1.0 I could help point you in the right direction on getting it working.

umamahe commented 11 years ago

hi gaffneyc thanks for your comments..

could you help me to point in the right direction on getting it working.

gaffneyc commented 11 years ago

I think there are two things you would need to do:

Update the gemspec for sunspot_rails to ">= 1.1.0"
Replace the persisted? call in SessionProxy with the Rails 2 version.

There might be more but those are the ones that appeared in my testing.