Proxy settings and version

gaffneyc / usps

USPS Webtools API for Ruby

MIT License

63 stars 54 forks source link

Proxy settings and version #20

Closed drewbailey closed 3 years ago

schleg commented 8 years ago

@drewbailey so this seems much like the other pull request but with a version bump. which one is the right one? please remove the extra request if you can. thanks

bensheldon commented 3 years ago

@drewbailey I'd be happy to merge this functionality, though I apologize that it's probably quite stale.

Please remove the version number; that will be bumped when a release is made.
I think this would be better to expose more generically as typhoeus_request_options because typhoeus's proxy settings alone has both proxy and proxyuserpwd options, and I can imagine there are other typhoeus settings a user may want to tweak without having to mirror them through this gem's API.

drewbailey commented 3 years ago

Hey, I no longer have context for this change 😁, and don't have a need for it at this time. Please feel free to close or use changes as you see fit, cheers.