Closed jmcclena closed 4 years ago
Merging #117 into master will increase coverage by
2.86%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #117 +/- ##
==========================================
+ Coverage 77.64% 80.50% +2.86%
==========================================
Files 46 46
Lines 8565 10111 +1546
==========================================
+ Hits 6650 8140 +1490
- Misses 1915 1971 +56
Impacted Files | Coverage Δ | |
---|---|---|
omas/omas_sample.py | 99.57% <100.00%> (+0.16%) |
:arrow_up: |
omas/tests/test_omas_plot.py | 99.33% <100.00%> (+0.02%) |
:arrow_up: |
omas/omas_setup.py | 85.33% <0.00%> (-0.39%) |
:arrow_down: |
omas/examples/omas_mongo_example.py | 92.10% <0.00%> (+1.62%) |
:arrow_up: |
omas/omas_core.py | 88.57% <0.00%> (+3.70%) |
:arrow_up: |
omas/omas_utils.py | 85.10% <0.00%> (+4.19%) |
:arrow_up: |
omas/omas_json.py | 88.37% <0.00%> (+5.51%) |
:arrow_up: |
omas/omas_plot.py | 80.60% <0.00%> (+7.06%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 545509f...919f151. Read the comment docs.
👍 @jmcclena can you please add the @add_to_ODS
to the new sample functions
@jmcclena now that the nbi and ec are being regression tested some issues came up: https://travis-ci.com/github/gafusion/omas/builds/173921455
looks like pi --> numpy.pi
@jmcclena now that the nbi and ec are being regression tested some issues came up: https://travis-ci.com/github/gafusion/omas/builds/173921455
looks like
pi --> numpy.pi
ahhh thanks for finding that. One day I'll get my own version of omas working on iris again so I can debug these things myself.
@eldond