TimSlendebroek commented 4 years ago

new method for ods.physics_summary_total_powers, should throw errors if the source.identifier.index isn't filled!

Should be easy to add systems or totals if they are added to the data schema by appending the two dicts.

TimSlendebroek commented 4 years ago

I have a feeling that the regression test failing isn't my fault this time

codecov[bot] commented 4 years ago

Codecov Report

Merging #119 into master will increase coverage by 0.74%. The diff coverage is 93.18%.

@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
+ Coverage   78.83%   79.58%   +0.74%     
==========================================
  Files          46       46              
  Lines        8745     8776      +31     
==========================================
+ Hits         6894     6984      +90     
+ Misses       1851     1792      -59

Impacted Files	Coverage Δ
omas/omas_physics.py	`71.96% <92.30%> (+7.26%)`	:arrow_up:
omas/tests/test_omas_physics.py	`96.04% <100.00%> (+0.06%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 39f15ee...52cd024. Read the comment docs.

jmcclena commented 4 years ago

👍

gafusion / omas

added physics_total_powers method to ods and couple it to tau_e #119

Codecov Report