search

gafusion / omas

Ordered Multidimensional Array Structure
http://gafusion.github.io/omas
MIT License
30 stars 15 forks source link

Add start of list of formatted physics symbols for IMAS quantities #126

Closed eldond closed 3 years ago

eldond commented 3 years ago
codecov[bot] commented 3 years ago

Codecov Report

Merging #126 into master will increase coverage by 0.09%. The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
+ Coverage   79.42%   79.52%   +0.09%     
==========================================
  Files          47       48       +1     
  Lines        8935     8998      +63     
==========================================
+ Hits         7097     7156      +59     
- Misses       1838     1842       +4
Impacted Files Coverage Δ
omas/tests/test_omas_core.py 96.21% <92.85%> (-0.17%) :arrow_down:
omas/omas_symbols.py 94.23% <94.23%> (ø)
omas/omas_core.py 84.78% <100.00%> (+0.01%) :arrow_up:
omas/omas_plot.py 78.61% <100.00%> (-0.06%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3cb3b72...5b305d4. Read the comment docs.

eldond commented 3 years ago

@orso82 Okay, great. This makes it pretty clear what needs to be done to extend the symbols later. Then to use the symbols, I just import PhysicsSymbols, right? OOHHH and you made it so I can just feed in whatever location I want without bothering to strip/split/whatever it myself, didn't you!? So convenient!

eldond commented 3 years ago

@orso82 I'm finding it pretty convenient that you rigged it so I can do latexit[thing] instead of latexit(thing), because I can also do latexit.get(thing, thing) and that's really clear.