Closed eldond closed 3 years ago
Merging #137 into master will increase coverage by
0.01%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #137 +/- ##
==========================================
+ Coverage 79.55% 79.56% +0.01%
==========================================
Files 50 50
Lines 9762 9769 +7
==========================================
+ Hits 7766 7773 +7
Misses 1996 1996
Impacted Files | Coverage Δ | |
---|---|---|
omas/omas_core.py | 85.39% <100.00%> (+0.02%) |
:arrow_up: |
omas/tests/test_omas_core.py | 96.79% <100.00%> (+0.04%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update eec0bc6...6fb6d48. Read the comment docs.
@eldond thank you
@orso82 we didn't update the version number on this one. What's the best way for OMFIT scripts to test for this OMAS version in order to decide whether tests are enabled or not? Not having this change causes one of my tests to fail and it should just be skipped if an outdated OMAS version is in use.
I figured it out for this one thing: https://github.com/gafusion/OMFIT-source/blob/grade_eq/regression/test_omas_utils.py#L35-L43
@eldond see 44319c1